NFD » ndn-cxx

Design:

• Pure virtual base class NetworkMonitor::ImplBase is introduced. It is a friend of NetworkMonitor, and offers protected methods to modify NetworkMonitor data structures or emit signals on it. ImplBase type is public API.
• Existing Impl class inherit from ImplBase. It is not a friend of NetworkMonitor, but accesses NetworkMonitor data structures and signals via ImplBase protected methods. Impl type is not public API.
• NetworkMonitor constructor takes unique_ptr<NetworkMonitor::ImplBase>, which defaults to nullptr. Passing nullptr causes the constructor to internally make an Impl instance.
• NetworkInterface type setters are made public. NetworkMonitor APIs that return NetworkInterface are changed to return const NetworkInterface instead so that setters cannot be invoked by outsider.
• MockImpl class inherits from ImplBase and exposes its protected methods as public. To make a mock NetworkMonitor, pass a MockImpl instance to NetworkMonitor constructor.

https://gerrit.named-data.net/3978 patchset1 illustrates some of the API changes. I've skipped macOS variant for now. It also does not include MockImpl yet.

https://gerrit.named-data.net/3978 patchset2 brings the public API design of MockNetworkMonitor. It's structured as a subclass of NetworkMonitor rather than an Impl, because the Impl is passed by unique_ptr to NetworkMonitor and thus is solely owned by NetworkMonitor, so it's unsafe for the caller to keep a reference to an Impl. Instead, MockNetworkMonitor can internally manage an Impl and forward calls to it.