Project

General

Profile

Actions
Copy link

Task #4464

closed

Make SegmentFetcher pure Signal-based

Added by Muktadir Chowdhury almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Newberry
Category:
Utils
Target version:
v0.7
Start date:
Due date:
% Done:

100%

Estimated time:

Description

As per the discussion in #4438-6 and #4438-8, we should make the SegmentFetcher module Signal based. Right now, it is a hybrid of callback and signal that is inconsistent, and reduce readability and maintainability.

Related issues 2 (0 open — 2 closed)

Blocks ndn-cxx - Feature #4364: Implement congestion control in SegmentFetcherClosedEric Newberry

Actions
Blocks ndn-cxx - Task #4555: SegmentFetcher: eliminate selector usageClosedEric Newberry

Actions
Actions
Copy link
 #1

Updated by Davide Pesavento almost 7 years ago

  • Category set to Utils
  • Start date deleted (01/15/2018)
Actions
Copy link
 #2

Updated by Eric Newberry over 6 years ago

  • Assignee set to Eric Newberry
Actions
Copy link
 #3

Updated by Eric Newberry over 6 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by Eric Newberry over 6 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Junxiao Shi over 6 years ago

  • Blocks Feature #4364: Implement congestion control in SegmentFetcher added
Actions
Copy link
 #6

Updated by Eric Newberry over 6 years ago

  • Target version set to v0.7
Actions
Copy link
 #7

Updated by Eric Newberry over 6 years ago

  • Status changed from Code review to Closed
Actions
Copy link
 #8

Updated by Davide Pesavento over 6 years ago

  • Blocks Task #4555: SegmentFetcher: eliminate selector usage added
Actions
Copy link
 #9

Updated by Junxiao Shi over 6 years ago

20180910 NFD call agreed on the following deprecated feature removal policy:

  • A deprecated feature may be removed 90 days after it was deprecated.
  • A 7-day notice to nfd-dev is required before the removal.

https://gerrit.named-data.net/#/c/ndn-cxx/+/4929/ is removing the deprecated SegmentFetcher::fetch function. There was a concern about whether this Change must wait for a release, or it just needs a 5-day notice as we did in 2014. It has been more than 90 days since the deprecation. Under the policy recorded above, developer needs to send a 7-day notice.

Actions
Copy link
 #10

Updated by Davide Pesavento over 6 years ago

Junxiao Shi wrote:

  • A deprecated feature may be removed 90 days after it was deprecated.

I thought Lixia said after 90 days OR the next release, whichever comes first. Did I mishear?

Actions
Copy link

Also available in: Atom PDF