Task #4464
closed
Make SegmentFetcher pure Signal-based
Added by Muktadir Chowdhury almost 7 years ago.
Updated about 6 years ago.
Description
As per the discussion in #4438-6 and #4438-8, we should make the SegmentFetcher module Signal based. Right now, it is a hybrid of callback and signal that is inconsistent, and reduce readability and maintainability.
- Category set to Utils
- Start date deleted (
01/15/2018)
- Assignee set to Eric Newberry
- Status changed from New to In Progress
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
- Blocks Feature #4364: Implement congestion control in SegmentFetcher added
- Target version set to v0.7
- Status changed from Code review to Closed
- Blocks Task #4555: SegmentFetcher: eliminate selector usage added
20180910 NFD call agreed on the following deprecated feature removal policy:
- A deprecated feature may be removed 90 days after it was deprecated.
- A 7-day notice to nfd-dev is required before the removal.
https://gerrit.named-data.net/#/c/ndn-cxx/+/4929/ is removing the deprecated SegmentFetcher::fetch
function. There was a concern about whether this Change must wait for a release, or it just needs a 5-day notice as we did in 2014. It has been more than 90 days since the deprecation. Under the policy recorded above, developer needs to send a 7-day notice.
Junxiao Shi wrote:
- A deprecated feature may be removed 90 days after it was deprecated.
I thought Lixia said after 90 days OR the next release, whichever comes first. Did I mishear?
Also available in: Atom
PDF