NFD » ndn-cxx

Question was raised in https://gerrit.named-data.net/#/c/ndn-cxx/+/5066/1/ndn-cxx/detail/common-pch.hpp about whether common-pch.hpp should be installed.
I don't understand how common-pch.hpp works. Can someone explain?

pch = precompiled header. None of the precompiled headers should be installed, as they are only used to "speed up" compilation and only within the build system itself, they are not (and should not) be explicitly included anywhere.

It has been suggested that there are more headers that can go into 'detail' now that it's installed:

• net/asio-fwd.hpp: yes
• util/cf-releaser-osx.hpp: yes
• util/cf-string-osx.hpp: yes
• util/sqlite3-statement.hpp: no, used by repo-ng
• packet-base.hpp: yes

I'll move the "yes" ones in another commit, as moving common.hpp is already complex enough.

Probably you can add transport/stream-transport{,-with-resolver}-impl.hpp to the list.
I'm not sure about tag-host.hpp

https://gerrit.named-data.net/5069 PacketBase and TagHost
I don't see TagHost being used elsewhere so I moved it. I'll confirm with ndn-cxx-breaks.

https://gerrit.named-data.net/5070 asio-fwd
I'm moving it to ndn-cxx/detail/ rather than ndn-cxx/net/detail/ because it's being used by more than ndn-cxx/net/*.

https://gerrit.named-data.net/5071 StreamTransportImpl
This should be safe.

https://gerrit.named-data.net/5072 CFReleaser and cfstring
I can't test it because I no longer have account on monaco.

ndn-cxx-breaks logs before and after.
ndns is broken by these changed, and it's fixed in https://gerrit.named-data.net/5073 .
repo-ng has problems in unit testing, which is unrelated.
NLSR gained a new dependency and is not working in ndn-cxx-breaks at the moment.