Install implementation detail headers
So far the headers in
detail directory are not installed to the target system.
Some headers, such as
common.hpp, are implementation detail but their headers should be installed so that other headers can include them.
This task is to introduce a directory for installed implementation detail headers:
impldirectory (renamed from
detail) contains implementation detail with non-installed headers.
detaildirectory contains implementation detail with installed headers.
#5 Updated by Junxiao Shi 7 months ago
Question was raised in https://gerrit.named-data.net/#/c/ndn-cxx/+/5066/1/ndn-cxx/detail/common-pch.hpp about whether
common-pch.hpp should be installed.
I don't understand how
common-pch.hpp works. Can someone explain?
#7 Updated by Junxiao Shi 7 months ago
It has been suggested that there are more headers that can go into 'detail' now that it's installed:
- net/asio-fwd.hpp: yes
- util/cf-releaser-osx.hpp: yes
- util/cf-string-osx.hpp: yes
- util/sqlite3-statement.hpp: no, used by repo-ng
- packet-base.hpp: yes
I'll move the "yes" ones in another commit, as moving
common.hpp is already complex enough.
#9 Updated by Junxiao Shi 7 months ago
https://gerrit.named-data.net/5069 PacketBase and TagHost
I don't see TagHost being used elsewhere so I moved it. I'll confirm with ndn-cxx-breaks.
I'm moving it to
ndn-cxx/detail/ rather than
ndn-cxx/net/detail/ because it's being used by more than
This should be safe.
https://gerrit.named-data.net/5072 CFReleaser and cfstring
I can't test it because I no longer have account on monaco.