Task #4782
closed
Install implementation detail headers
Added by Junxiao Shi almost 6 years ago.
Updated almost 6 years ago.
Description
So far the headers in detail directory are not installed to the target system.
Some headers, such as common.hpp, are implementation detail but their headers should be installed so that other headers can include them.
This task is to introduce a directory for installed implementation detail headers:
impl directory (renamed from detail) contains implementation detail with non-installed headers.detail directory contains implementation detail with installed headers.
- Blocked by Task #3084: Rename "src" folder to "ndn-cxx" added
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
pch = precompiled header. None of the precompiled headers should be installed, as they are only used to "speed up" compilation and only within the build system itself, they are not (and should not) be explicitly included anywhere.
It has been suggested that there are more headers that can go into 'detail' now that it's installed:
- net/asio-fwd.hpp: yes
- util/cf-releaser-osx.hpp: yes
- util/cf-string-osx.hpp: yes
- util/sqlite3-statement.hpp: no, used by repo-ng
- packet-base.hpp: yes
I'll move the "yes" ones in another commit, as moving common.hpp is already complex enough.
Probably you can add transport/stream-transport{,-with-resolver}-impl.hpp to the list.
I'm not sure about tag-host.hpp
ndn-cxx-breaks logs before and after.
ndns is broken by these changed, and it's fixed in https://gerrit.named-data.net/5073 .
repo-ng has problems in unit testing, which is unrelated.
NLSR gained a new dependency and is not working in ndn-cxx-breaks at the moment.
- Status changed from Code review to Closed
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by