Feature #4805
closedProcess CanBePrefix and drop Selectors
100%
Description
In PIT and CS, process Interest CanBePrefix element and stop processing deprecated Selectors.
This includes necessary adjustments to PIT structure, as well as deleting old test cases.
Updated by Junxiao Shi almost 6 years ago
- Blocked by Feature #4567: Encode Interest into v0.3 format and drop support for v0.2 format added
Updated by Junxiao Shi over 5 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
Updated by Junxiao Shi over 5 years ago
https://gerrit.named-data.net/5399 eliminates Selectors from CS tests; it also promotes FindFixture
to CsFixture
for simplifying CS policy tests.
Rationale for changes in TestCs/Find
suite:
- EmptyInterestName: deleting because zero-component Interest name is forbidden by spec
- ExactName: spliting to ExactName (CanBePrefix=false) and ExactName_Cbp (CanBePrefix=true)
- EmptyDataName: changing to FullName_EmptyDataName with implicit digest included in Interest name, because zero-component Interest name is forbidden by spec
- Leftmost: renaming to PrefixName and adding CanBePrefix=true; also creating PrefixName_NoCbp with CanBePrefix=false
- Rightmost, MinSuffixComponent, MaxSuffixComponent, DigestOrder, DigestExclude: deleting because Selectors are gone
Updated by Junxiao Shi over 5 years ago
https://gerrit.named-data.net/5402 stops processing ChildSelector in CS implementation. It also converts some function objects into template arguments for better performance.
Processing of other Selectors comes from Interest::matchesData
that belongs to #4913.
Updated by Junxiao Shi over 5 years ago
Currently, I'm simply removing ChildSelector processing without further optimization.
I recognize the opportunity of reducing "prefix range" when CanBePrefix is unset, but I'd defer that to #4914.
Updated by Junxiao Shi over 5 years ago
From https://gerrit.named-data.net/5402:
code is fine but this should be merged after #4916
I disagree. According to 0.6.5 release notes:
Note that this is the last release that encodes to NDN packet format version 0.2.1. A future release will continue to decode v0.2.1 format, but will encode to v0.3 format.
There's no need to wait for any more releases.
Updated by Junxiao Shi over 5 years ago
- % Done changed from 50 to 70
https://gerrit.named-data.net/5443 eliminates Selectors from PIT tests.
Updated by Junxiao Shi over 5 years ago
- Status changed from In Progress to Code review
- % Done changed from 70 to 100
Given the changes needed to drop Selectors processing in PIT is minimal, they are now part of Change 5443.
There are a lot of optimization possible after these changes, but they should belong to another issue.
Updated by Junxiao Shi over 5 years ago
- Blocked by deleted (Feature #4567: Encode Interest into v0.3 format and drop support for v0.2 format)
Updated by Junxiao Shi over 5 years ago
- Status changed from Code review to Closed
Updated by Davide Pesavento over 5 years ago
- Blocks Feature #4567: Encode Interest into v0.3 format and drop support for v0.2 format added