Project

General

Profile

Task #4832

ndncatchunks: change version discovery logic

Added by Alex Afanasyev 3 months ago. Updated 26 days ago.

Status:
Closed
Priority:
Normal
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Iterative discovery method should no longer be the default, as it is being removed quite soon (with removal of selectors). We should have changed to fixed or any other simple "discovery" long time ago.


Related issues

Blocks ndn-tools - Task #4556: ndncatchunks: stop using SelectorsClosed

History

#1 Updated by Davide Pesavento 3 months ago

  • Start date deleted (02/05/2019)

Version discovery based on metadata is being implemented in #4556. After that is done, as I suggested elsewhere, we can remove modular discovery altogether and use the user-provided name directly if it already contains a version component (equivalent to current 'fixed'), otherwise use metadata.

#2 Updated by Davide Pesavento 3 months ago

  • Subject changed from Switch default discovery method to ndncatchunks: switch default discovery method

#3 Updated by Junxiao Shi 3 months ago

  • Blocked by Task #4556: ndncatchunks: stop using Selectors added

#4 Updated by Junxiao Shi 3 months ago

  • Assignee set to Chavoosh Ghasemi

#5 Updated by Davide Pesavento about 2 months ago

  • Subject changed from ndncatchunks: switch default discovery method to ndncatchunks: change version discovery logic

#6 Updated by Junxiao Shi about 2 months ago

Change 5312 patchset 1 does not adequately implement #4832-1. It merely removes the -d option, but still have separate DiscoverVersionFixed and DiscoverVersionRealtime classes, i.e. version discovery modules.
To remove modular version discovery, combine all version discovery logic into one class or function that receives the user-supplied name as an input, and outputs a versioned name.

Furthermore, -d option cannot be abruptly removed because it breaks backwards compatibility of scripts that may still be using them. Instead, follow the standard deprecation procedure:

  1. Keep -d option but don't include it in the help message or manpage.
  2. If -d option is specified, ignore its value and print a warning message.
  3. Delete it after a standard deprecated cycle (90 days).

#7 Updated by Chavoosh Ghasemi 30 days ago

  • Status changed from New to In Progress

#8 Updated by Davide Pesavento 29 days ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

#9 Updated by Davide Pesavento 29 days ago

  • Blocked by deleted (Task #4556: ndncatchunks: stop using Selectors)

#10 Updated by Davide Pesavento 29 days ago

  • Blocks Task #4556: ndncatchunks: stop using Selectors added

#11 Updated by Davide Pesavento 26 days ago

  • Status changed from Code review to Closed

Also available in: Atom PDF