Task #4832
closed
ndncatchunks: change version discovery logic
100%
Description
Iterative discovery method should no longer be the default, as it is being removed quite soon (with removal of selectors). We should have changed to fixed or any other simple "discovery" long time ago.
Updated by Davide Pesavento over 5 years ago
- Start date deleted (
02/05/2019)
Version discovery based on metadata is being implemented in #4556. After that is done, as I suggested elsewhere, we can remove modular discovery altogether and use the user-provided name directly if it already contains a version component (equivalent to current 'fixed'), otherwise use metadata.
Updated by Davide Pesavento over 5 years ago
- Subject changed from Switch default discovery method to ndncatchunks: switch default discovery method
Updated by Junxiao Shi over 5 years ago
- Blocked by Task #4556: ndncatchunks: stop using Selectors added
Updated by Davide Pesavento over 5 years ago
- Subject changed from ndncatchunks: switch default discovery method to ndncatchunks: change version discovery logic
Updated by Junxiao Shi over 5 years ago
Change 5312 patchset 1 does not adequately implement #4832-1. It merely removes the -d option, but still have separate DiscoverVersionFixed and DiscoverVersionRealtime classes, i.e. version discovery modules.
To remove modular version discovery, combine all version discovery logic into one class or function that receives the user-supplied name as an input, and outputs a versioned name.
Furthermore, -d option cannot be abruptly removed because it breaks backwards compatibility of scripts that may still be using them. Instead, follow the standard deprecation procedure:
- Keep
-doption but don't include it in the help message or manpage. - If
-doption is specified, ignore its value and print a warning message. - Delete it after a standard deprecated cycle (90 days).
Updated by Chavoosh Ghasemi over 5 years ago
- Status changed from New to In Progress
Updated by Davide Pesavento over 5 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
Updated by Davide Pesavento over 5 years ago
- Blocked by deleted (Task #4556: ndncatchunks: stop using Selectors)
Updated by Davide Pesavento over 5 years ago
- Blocks Task #4556: ndncatchunks: stop using Selectors added
Updated by Davide Pesavento over 5 years ago
- Status changed from Code review to Closed
Updated by Junxiao Shi about 5 years ago
- Related to Feature #5021: ndncatchunks: support unversioned data retrieval added