Project

General

Profile

Actions

Bug #5022

closed

self-learning: check if out-record of the PIT Entry exists before accessing it

Added by Teng Liang over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
Forwarding
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

In SelfLearningStrategy::afterReceiveData, StrategyInfo is accessed on the out-record of the PIT entry without checking if the out-record exits or not. This leads to NFD crashing in some cases, where PIT entries exist but out-record does not. This bug was found during an extensive testing.


Related issues 1 (0 open1 closed)

Blocks NFD - Task #5045: Release 0.7.0ClosedAlex Afanasyev

Actions
Actions #1

Updated by Teng Liang over 4 years ago

  • Tags set to SelfLearning
  • Tracker changed from Task to Bug
  • Category set to Forwarding
  • Status changed from In Progress to Code review
  • Assignee set to Teng Liang
Actions #2

Updated by Davide Pesavento over 4 years ago

  • Target version set to v0.7
Actions #3

Updated by Teng Liang over 4 years ago

  • Subject changed from self-learning strategy: check if out-record of the PIT Entry exists before accessing it to self-learning: check if out-record of the PIT Entry exists before accessing it
Actions #4

Updated by Davide Pesavento over 4 years ago

What's the plan here? I see this is marked "urgent" and for the v0.7 milestone, but there's no corresponding patch in gerrit despite "code review" status. Do you want to fix this for v0.7 or not?

Actions #5

Updated by Teng Liang over 4 years ago

Was planning to merge this patch with the self-learning improvement code. After a second thought, this task is more urgent, so I restored the commit on Gerrit.

Actions #6

Updated by Davide Pesavento over 4 years ago

Actions #7

Updated by Davide Pesavento over 4 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
Actions #8

Updated by Davide Pesavento over 4 years ago

  • Start date deleted (10/12/2019)
Actions

Also available in: Atom PDF