Task #2456
closedSimplify nfd-status using SegmentFetcher
Added by Alex Afanasyev almost 10 years ago. Updated over 9 years ago.
Files
nfd-status.cpp (27.8 KB) nfd-status.cpp | Yukai Tu, 05/25/2015 08:35 PM | ||
20150627154553.tgz (131 KB) 20150627154553.tgz | integ 2145,3 | Junxiao Shi, 06/27/2015 09:35 AM | |
20150629175143.tgz (135 KB) 20150629175143.tgz | integ 2145,5 | Junxiao Shi, 06/29/2015 12:35 PM |
Updated by Yukai Tu over 9 years ago
- Status changed from New to In Progress
- Assignee changed from Teng Liang to Yukai Tu
In SegmentFetcher, if data without finalBlockId, it will emit next Interest. In NfdStatus::fetchVersionInformation(), NfdStatus emit "/localhost/nfd/status", but statusServer doesn't have publisher, which means it can't set finalBlockId in Data, and it doesn't have second data. So it will fail to fetch "/localhost/nfd/status". Add setFinalBlockId in statusServer can solve the problem. Other fetch can be rewrited using SegmentFetcher successfully.
Updated by Junxiao Shi over 9 years ago
ForwarderStatus is not StatusDataset, so fetching it is a simple Interest, not SegmentFetcher
.
Updated by Yukai Tu over 9 years ago
So we don't rewrite NfdStatus::fetchVersionInformation() using SegmentFetcher, just express one Interest?
Updated by Junxiao Shi over 9 years ago
note-5 is correct. SegmentFetcher
is only applicable to StatusDataset.
Updated by Yukai Tu over 9 years ago
- File nfd-status.cpp nfd-status.cpp added
- Status changed from In Progress to Code review
- % Done changed from 0 to 80
I have tested and it works, for you to review.
Updated by Junxiao Shi over 9 years ago
Please submit a patchset to Gerrit for review.
Updated by Junxiao Shi over 9 years ago
- File 20150627154553.tgz 20150627154553.tgz added
- Subject changed from Rewrite/simplify nfd-status using SegmentFetcher to Simplify nfd-status using SegmentFetcher
Updated by Junxiao Shi over 9 years ago
- File 20150629175143.tgz 20150629175143.tgz added
- Status changed from Code review to Closed
- % Done changed from 80 to 100
Updated by Junxiao Shi over 9 years ago
Why isn't validation done in the code?
SegmentFetcher validation API is incomplete, see #2734.
There isn't a solution for how to obtain NFD's public key.
It should be an out-of-band method, such as reading from a file (owned by root, 0644 permission).