Project

General

Profile

Actions
Copy link

Task #2464

closed

code-style: member initialization list

Added by Junxiao Shi over 10 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Docs
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
1.00 h

Description

Update rule 1.13 to restrict putting complex expressions in member initialization list.

Actions
Copy link
 #1

Updated by Alex Afanasyev over 10 years ago

Seriously? I'm against of introducing any new unnecessary rules or guidelines.

Actions
Copy link
 #2

Updated by Junxiao Shi over 10 years ago

This was suggested by @Davide in Change I3cb870b13ba60d255162862c7dd0053ec5b578c4 patchset 5 tools/ndn-autoconfig/main.cpp line 65.

I neither agree nor disagree with this proposed rule.

Actions
Copy link
 #3

Updated by Davide Pesavento over 10 years ago

Err... no, I never proposed a rule, nor I suggested or asked to amend an existing one. It was just a minor comment and I even +1'd the change.

This task should be rejected in my opinion. Let's not introduce too much bureaucracy. Just use common sense when writing code AND when applying code style rules.

Actions
Copy link
 #4

Updated by Junxiao Shi over 10 years ago

  • Status changed from New to Rejected

I disagree with assuming the existence of "common sense".

Rules should be defined so that developers can follow them mechanically, and reviewers can enforce them mechanically.

Rules should be clear and unambigious enough so that no dispute should arise for whether a piece of code is violating a rule (when no exception is requested).

Nevertheless this one is Rejected as requested by @Davide.

Actions
Copy link

Also available in: Atom PDF