Task #2464
closed
code-style: member initialization list
Added by Junxiao Shi over 10 years ago.
Updated over 10 years ago.
Description
Update rule 1.13 to restrict putting complex expressions in member initialization list.
Seriously? I'm against of introducing any new unnecessary rules or guidelines.
This was suggested by @Davide in Change I3cb870b13ba60d255162862c7dd0053ec5b578c4 patchset 5 tools/ndn-autoconfig/main.cpp line 65.
I neither agree nor disagree with this proposed rule.
Err... no, I never proposed a rule, nor I suggested or asked to amend an existing one. It was just a minor comment and I even +1'd the change.
This task should be rejected in my opinion. Let's not introduce too much bureaucracy. Just use common sense when writing code AND when applying code style rules.
- Status changed from New to Rejected
I disagree with assuming the existence of "common sense".
Rules should be defined so that developers can follow them mechanically, and reviewers can enforce them mechanically.
Rules should be clear and unambigious enough so that no dispute should arise for whether a piece of code is violating a rule (when no exception is requested).
Nevertheless this one is Rejected as requested by @Davide.
Also available in: Atom
PDF