Project

General

Profile

Actions
Copy link

Feature #2698

closed

ping: allow <1000ms interval

Added by Junxiao Shi over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Newberry
Start date:
Due date:
% Done:

100%

Estimated time:
0.50 h

Description

ndnping has 1000ms as both default interval and minimum interval.

In certain experiments, it's desirable to use a less than 1000ms interval.

The minimum interval should be changed to 1ms, while the default can be kept as 1000ms.

Actions
Copy link
 #1

Updated by Alex Afanasyev over 10 years ago

+1

Actions
Copy link
 #2

Updated by Eric Newberry over 10 years ago

  • Status changed from New to In Progress
  • Assignee set to Eric Newberry
Actions
Copy link
 #3

Updated by Eric Newberry over 10 years ago

  • Status changed from In Progress to Code review
Actions
Copy link
 #4

Updated by Junxiao Shi over 10 years ago

IP ping allows 200ms minimum interval for non-root, and 1ms minimum interval for root.

Should we impose different minimum interval limits for non-root and root as well?

Actions
Copy link
 #5

Updated by Eric Newberry over 10 years ago

Could be a useful feature, but the code to do so would probably be very platform-specific.

Actions
Copy link
 #6

Updated by Junxiao Shi over 10 years ago

I'm unsure whether different minimum for non-root and root is a good design.
I'd like to hear opinions of Alex, Davide, Vince, Lan.

the code to do so would probably be very platform-specific.

I disagree. geteuid() == 0 should be sufficient.

Actions
Copy link
 #7

Updated by Eric Newberry over 10 years ago

Junxiao Shi wrote:

I disagree. geteuid() == 0 should be sufficient.

This would only work on POSIX-compliant systems. However, we're only planning on supporting Unix-like systems for the forseeable future, right?

Actions
Copy link
 #8

Updated by Davide Pesavento over 10 years ago

Junxiao Shi wrote:

IP ping allows 200ms minimum interval for non-root, and 1ms minimum interval for root.

Should we impose different minimum interval limits for non-root and root as well?

No, I don't think such a restriction for non-root users makes sense in our case.

In the ping(8) case, I suppose it has been introduced because ping is a setuid binary that exposes a functionality that is normally root-only (sending of ICMP echo packets) to regular users. The NDN trust model is different.

Actions
Copy link
 #9

Updated by Vince Lehman over 10 years ago

Davide Pesavento wrote:

In the ping(8) case, I suppose it has been introduced because ping is a setuid binary that exposes a functionality that is normally root-only (sending of ICMP echo packets) to regular users. The NDN trust model is different.

I agree. I don't see a reason for making the restriction in ndnping.

Actions
Copy link
 #10

Updated by Junxiao Shi over 10 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF