NFD » ndn-tools

+1

IP ping allows 200ms minimum interval for non-root, and 1ms minimum interval for root.

Should we impose different minimum interval limits for non-root and root as well?

Could be a useful feature, but the code to do so would probably be very platform-specific.

I'm unsure whether different minimum for non-root and root is a good design.
I'd like to hear opinions of Alex, Davide, Vince, Lan.

the code to do so would probably be very platform-specific.

I disagree. geteuid() == 0 should be sufficient.

Junxiao Shi wrote:

I disagree. geteuid() == 0 should be sufficient.

This would only work on POSIX-compliant systems. However, we're only planning on supporting Unix-like systems for the forseeable future, right?

Junxiao Shi wrote:

IP ping allows 200ms minimum interval for non-root, and 1ms minimum interval for root.

Should we impose different minimum interval limits for non-root and root as well?

No, I don't think such a restriction for non-root users makes sense in our case.

In the ping(8) case, I suppose it has been introduced because ping is a setuid binary that exposes a functionality that is normally root-only (sending of ICMP echo packets) to regular users. The NDN trust model is different.

Davide Pesavento wrote:

In the ping(8) case, I suppose it has been introduced because ping is a setuid binary that exposes a functionality that is normally root-only (sending of ICMP echo packets) to regular users. The NDN trust model is different.

I agree. I don't see a reason for making the restriction in ndnping.