Project

General

Profile

Actions

Feature #3997

closed

Support using FaceId in creating a route

Added by Lei Pi over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui
Start date:
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

It will be more friendly for user to create new route with an existing face's id.


Related issues 2 (0 open2 closed)

Related to NFD-android - Bug #4632: Cannot add route to existing faceClosed

Actions
Related to NFD-android - Feature #3998: Provide a list of existing faces in "create new route" dialogClosedLei Pi

Actions
Actions #1

Updated by Alex Afanasyev over 6 years ago

  • Is duplicate of Bug #4632: Cannot add route to existing face added
Actions #2

Updated by Junxiao Shi over 6 years ago

Asking the user to type the Face ID is error prone.

A better user experience is:

  1. on "Faces" tab, long press an existing face.
  2. a popup menu appears with menu items like "destroy face", "view face details", and "add route".
  3. selecting the "add route" menu item brings up the "add route" dialog where the Face ID is pre-populated.
Actions #3

Updated by Junxiao Shi over 6 years ago

  • Is duplicate of deleted (Bug #4632: Cannot add route to existing face)
Actions #4

Updated by Junxiao Shi over 6 years ago

  • Blocked by Bug #4632: Cannot add route to existing face added
Actions #5

Updated by Junxiao Shi over 6 years ago

This issue does not duplicate #4632. #4632 would allow the user to enter the same FaceUri as an existing face, while this issue would allow the user to enter a Face ID.

Actions #6

Updated by Ju Pan about 6 years ago

Is this the implementation of this feature still ongoing? We may need this feature for #4761.

Actions #7

Updated by Ju Pan about 6 years ago

  • Assignee changed from Lei Pi to Ju Pan
  • % Done changed from 50 to 0
Actions #8

Updated by Ju Pan about 6 years ago

Current facelist implementation:

  • short click --> go to face details
  • long press --> mutlichoice for batch deletion.

I can think of two options to go with:

  • Keep long press for multichoice batch deletion, but change short click to trigger a floating menu or action bar menu including "face details" and "add route" buttons.
  • No more multichoice batch deletion, change long press to trigger a floating menu or action bar menu including "add route" and "delete face" buttons, short click still triggers "face details".

Apart from letting the user click on face to add route, I am also thinking of adding "add route by face id" functionality in routes list screen. In the routes list screen, when user click "+" to add a route, we show two radio buttons (faceID and faceUri) in AlertDialog for user to check, then user fills in the face ID or face Uri respectively.

Any comments?

Actions #9

Updated by Davide Pesavento about 6 years ago

A modern UX pattern in Android apps is using swipe actions: the user swipes left or right on the list item and triggers an action for that item. This can be used for destroying a face for example.

If swipe actions are more complicated to implement, then I have a slight preference for your second option: use long press to trigger a floating menu or similar. We lose batch deletion of multiple faces but I don't think that's a frequent action.

I am also thinking of adding "add route by face id" functionality in routes list screen

No objections.

Actions #10

Updated by Ju Pan almost 6 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 70
Actions #11

Updated by Ju Pan almost 6 years ago

Current design:

On Face list:

  • long press to show a floating menu containing "Add Route" and "Delete"
  • short click to show face details

On Route list:

  • Add functionality to add route by face id.

A bug existing even before this change: after deleting the face, the user has to refresh the UI manually, otherwise the face is still shown in the list (bu logically, it's gone).

Actions #12

Updated by Davide Pesavento almost 6 years ago

  • Blocked by deleted (Bug #4632: Cannot add route to existing face)
Actions #13

Updated by Davide Pesavento almost 6 years ago

  • Related to Bug #4632: Cannot add route to existing face added
Actions #14

Updated by Davide Pesavento almost 6 years ago

  • Subject changed from Support using face id in creating a route to Support using FaceId in creating a route
  • Status changed from Code review to Closed
  • Start date deleted (03/16/2017)
  • % Done changed from 70 to 100
Actions #15

Updated by Davide Pesavento almost 6 years ago

  • Related to Feature #3998: Provide a list of existing faces in "create new route" dialog added
Actions

Also available in: Atom PDF