Project

General

Profile

Actions
Copy link

Bug #4135

closed

NLSR PPA release version does not show commit ID

Added by Ashlesh Gawande over 7 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Target version:
Minor Release v0.6.1
Start date:
06/15/2017
Due date:
% Done:

0%

Estimated time:

Description

nlsr -V shows only the major release version (ex: 0.3.2 instead os something like 0.3.2-commitid).

Actions
Copy link
 #1

Updated by Nicholas Gordon over 7 years ago

  • Priority changed from Normal to Low
  • Target version set to v0.4.0

If this is for consistency with NFD's version string, I think we need more than just the short commit. At first glance I don't fully understand their version string.

This doesn't create an ambiguity problem because they can check out the tag NLSR-0.3.2 to get this commit. At any rate, this can be set to low priority at least.

Actions
Copy link
 #2

Updated by Alex Afanasyev over 7 years ago

PPA package version already includes detailed version. nlsr -V should also should have shown the proper version, not sure why it is not doing it.

@Nick Check out git describe --help The version string is directly from it.

Actions
Copy link
 #3

Updated by Nicholas Gordon about 7 years ago

  • Target version changed from v0.4.0 to v0.5.0
Actions
Copy link
 #4

Updated by Nicholas Gordon almost 7 years ago

  • Target version changed from v0.5.0 to Minor release v0.5.1
Actions
Copy link
 #6

Updated by Alex Afanasyev almost 7 years ago

Version suppose to be passed through version.hpp.in script. Also, the tagged commits will not have any more details (only untagged commits supposed to have -commit-id). I have a small update to wscript, but it doesn't really do anything, just sync's up changes with NFD and fixed python3 support.

Actions
Copy link
 #7

Updated by Saurab Dulal over 5 years ago

  • Target version changed from Minor release v0.5.1 to v0.6.0
Actions
Copy link
 #8

Updated by Saurab Dulal almost 4 years ago

  • Target version changed from v0.6.0 to Minor Release v0.6.1
Actions
Copy link
 #9

Updated by Junxiao Shi almost 3 years ago

  • Tracker changed from Task to Bug
  • Status changed from New to Closed

This bug is not longer present in the current version.
From nightly build:

$ docker exec ndnnet_nlsr nlsr -V
0.6.0-14-gea94f83

Alex Afanasyev wrote in #note-6:

the tagged commits will not have any more details (only untagged commits supposed to have -commit-id)

Most of published PPA builds are coming from tagged commits so that they don't have -commit-id portion.

Actions
Copy link

Also available in: Atom PDF