Task #4135
NLSR PPA release version does not show commit ID
0%
Description
nlsr -V shows only the major release version (ex: 0.3.2 instead os something like 0.3.2-commitid).
Updated by Nicholas Gordon over 3 years ago
- Priority changed from Normal to Low
- Target version set to v0.4.0
If this is for consistency with NFD's version string, I think we need more than just the short commit. At first glance I don't fully understand their version string.
This doesn't create an ambiguity problem because they can check out the tag NLSR-0.3.2 to get this commit. At any rate, this can be set to low priority at least.
Updated by Alex Afanasyev over 3 years ago
PPA package version already includes detailed version. nlsr -V should also should have shown the proper version, not sure why it is not doing it.
@Nick Check out git describe --help The version string is directly from it.
Updated by Nicholas Gordon about 3 years ago
- Target version changed from v0.5.0 to Minor release v0.5.1
Updated by Ashlesh Gawande about 3 years ago
Could this be because we don't pass the version here:
https://github.com/named-data/NLSR/blob/350d58489b895526042d52213120b68ae9e3bdba/wscript#L104
like NFD does:
https://github.com/named-data/NFD/blob/cdf784598696a8c545b3b846fc090c40c657d7c9/wscript#L193
Updated by Alex Afanasyev about 3 years ago
Version suppose to be passed through version.hpp.in script. Also, the tagged commits will not have any more details (only untagged commits supposed to have -commit-id). I have a small update to wscript, but it doesn't really do anything, just sync's up changes with NFD and fixed python3 support.
Updated by Saurab Dulal over 1 year ago
- Target version changed from Minor release v0.5.1 to v0.6.0