Bug #4135
closed
NLSR PPA release version does not show commit ID
Added by Ashlesh Gawande over 7 years ago.
Updated almost 3 years ago.
Description
nlsr -V shows only the major release version (ex: 0.3.2 instead os something like 0.3.2-commitid).
- Priority changed from Normal to Low
- Target version set to v0.4.0
If this is for consistency with NFD's version string, I think we need more than just the short commit. At first glance I don't fully understand their version string.
This doesn't create an ambiguity problem because they can check out the tag NLSR-0.3.2
to get this commit. At any rate, this can be set to low priority at least.
PPA package version already includes detailed version. nlsr -V
should also should have shown the proper version, not sure why it is not doing it.
@Nick Check out git describe --help The version string is directly from it.
- Target version changed from v0.4.0 to v0.5.0
- Target version changed from v0.5.0 to Minor release v0.5.1
Version suppose to be passed through version.hpp.in
script. Also, the tagged commits will not have any more details (only untagged commits supposed to have -commit-id). I have a small update to wscript, but it doesn't really do anything, just sync's up changes with NFD and fixed python3 support.
- Target version changed from Minor release v0.5.1 to v0.6.0
- Target version changed from v0.6.0 to Minor Release v0.6.1
- Tracker changed from Task to Bug
- Status changed from New to Closed
This bug is not longer present in the current version.
From nightly build:
$ docker exec ndnnet_nlsr nlsr -V
0.6.0-14-gea94f83
Alex Afanasyev wrote in #note-6:
the tagged commits will not have any more details (only untagged commits supposed to have -commit-id)
Most of published PPA builds are coming from tagged commits so that they don't have -commit-id portion.
Also available in: Atom
PDF