NFD » ndn-cxx

There are two problems.

First, getpass is not properly detected, as seen in ndn-cxx/build/config.log:

----------------------------------------------------
Checking for function getpass
==>
#include <unistd.h>

int main(int argc, char **argv) {
        void *p;
        (void)argc; (void)argv;
        p=(void*)(getpass);
        ((void)(p));
        return 0;
}

<==
[1/2] Compiling ESC[32mbuild/.conf_check_bef817a4e1e3fc7a929916a51bee77c1/test.cppESC[0m

['/usr/bin/g++', '-O0', '-Og', '-g3', '-pedantic', '-Wall', '-Wextra', '-Werror', '-Wnon-virtual-dtor', '-Wno-unused-parameter', '-Wno-error=maybe-uninitialized', '-Wno-error=deprecated-declarations', '-Wno-missing-field-initializers', '-std=c++11', '-D_DEBUG', '-DHAVE_STD_TO_STRING=1', '-DHAVE_IS_DEFAULT_CONSTRUCTIBLE=1', '-DHAVE_IS_NOTHROW_MOVE_CONSTRUCTIBLE=1', '-DHAVE_IS_NOTHROW_MOVE_ASSIGNABLE=1', '-DHAVE_PTHREAD=1', '-DHAVE_RT=1', '../test.cpp', '-c', '-o', '/home/vagrant/ndn-cxx/build/.conf_check_bef817a4e1e3fc7a929916a51bee77c1/testbuild/test.cpp.1.o']
err: ../test.cpp: In function ‘int main(int, char**)’:
../test.cpp:6:19: error: ISO C++ forbids casting between pointer-to-function and pointer-to-object [-Werror=pedantic]
  p=(void*)(getpass);
                   ^
cc1plus: all warnings being treated as errors

from /home/vagrant/ndn-cxx: Test does not build: Traceback (most recent call last):
  File "/home/vagrant/ndn-cxx/.waf-1.8.9-849024857bd41c3cf8e87dc01ecf79b0/waflib/Configure.py", line 343, in run_build
    bld.compile()
  File "/home/vagrant/ndn-cxx/.waf-1.8.9-849024857bd41c3cf8e87dc01ecf79b0/waflib/Build.py", line 184, in compile
    raise Errors.BuildError(self.producer.error)
BuildError: Build failed
 -> task in 'testprog' failed (exit status 1): 
        {task 139639119270416: cxx test.cpp -> test.cpp.1.o}
['/usr/bin/g++', '-O0', '-Og', '-g3', '-pedantic', '-Wall', '-Wextra', '-Werror', '-Wnon-virtual-dtor', '-Wno-unused-parameter', '-Wno-error=maybe-uninitialized', '-Wno-error=deprecated-declarations', '-Wno-missing-field-initializers', '-std=c++11', '-D_DEBUG', '-DHAVE_STD_TO_STRING=1', '-DHAVE_IS_DEFAULT_CONSTRUCTIBLE=1', '-DHAVE_IS_NOTHROW_MOVE_CONSTRUCTIBLE=1', '-DHAVE_IS_NOTHROW_MOVE_ASSIGNABLE=1', '-DHAVE_PTHREAD=1', '-DHAVE_RT=1', '../test.cpp', '-c', '-o', '/home/vagrant/ndn-cxx/build/.conf_check_bef817a4e1e3fc7a929916a51bee77c1/testbuild/test.cpp.1.o']

not found
from /home/vagrant/ndn-cxx: The configuration failed
----------------------------------------------------

Second, error message is confusing when getpass is unavailable.
ndn::ndnsec::getPassword should print a warning indicating that getpass is unavailable so the relevant function cannot be used.

Addressing the first problem would mask the second problem, so the second problem should be fixed before the first one.

I think the configure-time detection was fixed in #4296, so on a normal build you cannot experience the confusing error message related to getpass.

This issue is no longer blocking the release, but the error message still should be fixed.