NFD » ndn-tools

Junxiao, you should have fixed ndnpeek before removing the deprecated functions. It looks bad that we have a core tool broken for several days.

should have fixed ndnpeek before removing the deprecated functions

I did not know it would be broken. Although I triggered the build, I didn't look at the logs until the Change was merged.

It looks bad that we have a core tool broken for several days.

ndnpeek is by no means a "core tool". I rarely use it in my deployments.
repo-ng and ndns are broken for months.
ndn-cxx has issued a "breaking changes warning" in last release notes, and breaking changes are no longer subject to 5-day notice period.
ndn-cxx would even merge change that breaks NFD, which I'm unhappy about.

In either case, I won't work on this issue, and I'll let Teng handle it.

Quick fix for the build failure: https://gerrit.named-data.net/4120

Junxiao Shi wrote:

I did not know it would be broken. Although I triggered the build, I didn't look at the logs until the Change was merged.

That's not an excuse.

ndnpeek is by no means a "core tool". I rarely use it in my deployments.

Yes it is. Together with chunks and ping, it's one of the first tools that people use when they want to try things out. Luckily, the build failure affects only the unit tests, so probably most users are not impacted.

We had multiple accidents like this even though we are always cautious, so let us be constructive.

My suggestion is to revert the commit that removed the deprecated functions from ndn-cxx.

I would be against that this time. That was quite ugly API and I prefer we switch to the better (and now the only correct based on spec) API of forwarding hint.

Is Teng still working on this?

I've forgotten this issue. If someone else wants to work on it, just take it, or I'll start working on it within this week.

What's the argument and format of delegation list in the command line? E.g.,

ndnpeek --delegation-list {preference=1,name=/A;preference=2,name=/B} ndn:/name

ndnpeek --delegation-list {preference=1,name=/A;preference=2,name=/B} ndn:/name

This syntax is acceptable. I’d prefer a shorter syntax:

--fh /A:1,/B:2

No need to invent special syntax for multiple hints. IIRC boost::program_options supports options that are vectors of things: you can specify the option multiple times on the command line and all values are merged together.

I'm trying to take the delegations as vector of strings in the command line:

("delegation-list,dl", po::value< std::vector<std::string> >(),
        "set Delegations of the ForwardingHint")

How can I load the vector of strings to the link in options? e.g.

options.link = [something-here](vm["delegation-list"].as< std::vector<std::string> >());

Currently the --link-file option uses io::load taking the filename in string and converts the input from the file to blocks:

options.link = io::load<Link>(vm["link-file"].as<std::string>());