ChronoSync

03/02/2018

10:33 AM Bug #4525 (New): Destructing a ChronoSync socket object shuts down the face

Currently the ChronoSync socket class accepts a reference to a Face object. I think this is intended to support using... Nicholas Gordon

02/13/2018

04:15 PM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

Two related commits:
- https://gerrit.named-data.net/#/c/4535/
- https://gerrit.named-data.net/#/c/4536/
Alex Afanasyev

11:45 AM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

If we don't, then may be we wouldn't see the error. On testbed, we ARE adding ndnlp headers now. Alex Afanasyev

11:25 AM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

If we don't set any tags on the data packet then the lpPacket should be empty and we would be sending a Data packet w... Ashlesh Gawande

02/12/2018

07:33 PM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

Ashlesh Gawande wrote:
> Okay, the user specified limit will replace `MAX_NDN_PACKET_SIZE` while comparing to syncR... Alex Afanasyev

07:32 PM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

The testbed size has grown considerably. Also, having separate chronosync prefixes for NAME and COORDINATE inflated t... Alex Afanasyev

06:18 PM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

Would it be possible to post the ChronoSync log before the crash from this node and other nodes?
When we used NSync ... Ashlesh Gawande

04:50 PM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

Okay, the user specified limit will replace MAX_NDN_PACKET_SIZE while comparing to syncReply size? Ashlesh Gawande

03:17 PM Bug #4140: ChronoSync sendSyncData can result in trying to send content exceeding the size of the packet

The solution is incomplete, as it didn't provision for NDNLPv2 headers, resulting in the following error
```
1518... Alex Afanasyev

10:32 AM Bug #4496 (Closed): ABI changes when ChronoSync compiled with/without debug mode

Alex Afanasyev

02/11/2018

07:46 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

We should tell that Crytpo++ and Boot.Log developers who are quite abusing this :) Alex Afanasyev

07:41 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

The lesson: don’t use preprocessor conditionals to add or remove fields in headers unless the defines are in a common... Junxiao Shi

02:09 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

Alex Afanasyev wrote:
> Davide discovered a changeable ABI when compiled with `_DEBUG` define.
Specifically, clas... Davide Pesavento

01:57 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

Davide discovered a changeable ABI when compiled with `_DEBUG` define. When compiling the snippet using `-D_DEBUG=1`... Alex Afanasyev

09:47 AM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

valgrind confirms the same memory error <https://travis-ci.org/yoursunny/TravisCI-temp/builds/340186679> Junxiao Shi

08:52 AM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

I'm able to reproduce this bug on Ubuntu 14.04.
<https://travis-ci.org/yoursunny/TravisCI-temp/builds/340164777> Junxiao Shi

05:39 PM Bug #4496 (Code review): ABI changes when ChronoSync compiled with/without debug mode

https://gerrit.named-data.net/4529 Alex Afanasyev

02:00 PM Bug #4496 (Closed): ABI changes when ChronoSync compiled with/without debug mode

There are several `ifdef` in header files that alter ABI depending on defines, which is a (or the) cause for #4495 an... Alex Afanasyev

02/10/2018

07:45 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

> So you're building only ndn-cxx with ASan, not ChronoSync..?
No. Everything was with `--debug` and `--with-sanit... Alex Afanasyev

01:14 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

Alex Afanasyev wrote:
> Repeated the same issue on 14.04 and 17.10.
>
> One things that I didn't specify original... Davide Pesavento

01:04 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

Repeated the same issue on 14.04 and 17.10.
One things that I didn't specify originally, ndn-cxx, ChronoSync, and ... Alex Afanasyev

02/09/2018

03:11 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

Ubuntu 17.10 x86_64 with standard gcc compiler and standard everything else. Davide Pesavento

02:43 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

Which specific Linux? I have stably reproduced it on macOS 10.13.3 with clang 9.0.0 (clang-900.0.39.2) and on Ubuntu... Alex Afanasyev

02/08/2018

09:59 PM Bug #4495: Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

I cannot reproduce the AddressSanitizer error on Linux using the test program in the description. Davide Pesavento

11:05 AM Bug #4495 (New): Strange buffer overflow / random crash of chronosync::Socket related to ndn::InMemoryStorage

The following snippet suppose to work without problems
test.cpp:
```
#include <iostream>
#include <sstream>
... Alex Afanasyev