Bug #2188: FaceManager creates UnixStreamChannel when listen=no - NFD - NDN project issue tracking system

Actions

Copy link

Bug #2188

closed

FaceManager creates UnixStreamChannel when listen=no

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Management

Target version:

v0.3

Start date:

11/17/2014

Due date:

% Done:

100%

Estimated time:

1.00 h

Description

Code snippet from mgmt/face-manager.cpp:

shared_ptr<UnixStreamChannel> unixChannel = factory->createChannel(path);

if (needToListen) {
  unixChannel->listen(bind(&FaceTable::add, &m_faceTable, _1),
                      UnixStreamChannel::ConnectFailedCallback());
}

UnixStreamChannel is useless when not listening, so its creation should be skipped altogether.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Anonymous over 9 years ago

Status changed from New to In Progress
Assignee set to Anonymous

I vaguely remember us having a similar problem with UDP faces. Should we just get rid of the "listen" option? (UDP also lacks a listen option after an earlier change).

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

I agree with deleting unix.listen option. To disable UnixStreamFace, operator must comment out the unix section.

Remember to update sample configuration file and NFD Developer Guide.

Actions

Copy link

Updated by Anonymous over 9 years ago

% Done changed from 0 to 80

I just noticed that disabling unix sockets prevents NRD from connecting to NFD. Should there be a way to configure the type of transport NRD uses? If so, should this be a separate change?

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

I just noticed that disabling unix sockets prevents NRD from connecting to NFD. Should there be a way to configure the type of transport NRD uses? If so, should this be a separate change?

I know the problem with NRD. I'll create a separate Bug.

Actions

Copy link

Updated by Alex Afanasyev over 9 years ago

I would say it is neither NFD or NRD problem. The issue is with default transport for Face class in ndn-cxx. I think the most straightforward way to solve this problem would be to have a compile-time option for ndn-cxx to select default transport. Or simply provide an option to disable unix socket support, which would make tcp/localhost a default transport.

Actions

Copy link